On Thu, Feb 09, 2012 at 04:58:15AM -0800, Ido Shayevitz wrote: > > > Hi, > > > > On Thu, Feb 09, 2012 at 02:04:30PM +0200, Ido Shayevitz wrote: > >> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > >> index 582df0b..c2fb969 100644 > >> --- a/drivers/usb/dwc3/gadget.c > >> +++ b/drivers/usb/dwc3/gadget.c > >> @@ -518,7 +518,7 @@ static int __dwc3_gadget_ep_enable(struct dwc3_ep > >> *dep, > >> if (ret) > >> return ret; > >> > >> - dep->desc = desc; > >> + dep->endpoint.desc = desc; > > > > isn't this already set by choose_ep_by_config() ?? > > Yes, I agree, but I think that as long as the api is ep->enable(ep*,desc*) > then we should keep this line, since it means that we need to enable the > endpoint with the given descriptor and not rely on the desc inside the ep. > In my opinion, when changing the api to ep->enable(ep*) as Sebastian > suggested, then we can remove this line. no no, makes no sense, actually. We will be adding something which we *know* will be removed. Please rework this part to remove that line you added on all UDCs. -- balbi
Attachment:
signature.asc
Description: Digital signature
