On Mon, Feb 06, 2012 at 10:49:07AM +0100, Johan Hovold wrote:
> Use dev_err_console in write path so that an error at least gets
> reported once.
>
> Reported-by: Stephen Hemminger <shemminger@xxxxxxxxxx>
> Signed-off-by: Johan Hovold <jhovold@xxxxxxxxx>
>
> --- a/drivers/usb/serial/generic.c
> +++ b/drivers/usb/serial/generic.c
> @@ -217,7 +217,7 @@ retry:
> clear_bit(i, &port->write_urbs_free);
> result = usb_submit_urb(urb, GFP_ATOMIC);
> if (result) {
> - dev_err(&port->dev, "%s - error submitting urb: %d\n",
> + dev_err_console(&port->dev, "%s - error submitting urb: %d\n",
> __func__, result);
Oops, I get the following warning with this patch applied:
drivers/usb/serial/generic.c: In function ‘usb_serial_generic_write_start’:
drivers/usb/serial/generic.c:220:3: warning: initialization from incompatible pointer type [enabled by default]
So I'm not going to apply it, or the 3/3 patch here.
What went wrong?
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
