Re: [PATCH 1/1] usb: gadget: Update all UDCs to use usb_endpoint_descriptor inside the struct usb_ep

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> * Felipe Balbi | 2012-02-07 22:27:32 [+0200]:
>
>>>  35 files changed, 176 insertions(+), 192 deletions(-)
>>
>>are you crazy ? To fix one single bug on f_serial you needed to change
>>ALL UDCs ?
>
> I fixed this bug in a smaller way.

I am just about to publish a new patch for fixing the bug on ep->disable
for all the UDCs, as talked today with Felipe.

> However as a cleanup you migh want to
> take something like this to elimiate the same information in two places.
> But this can be done on a per-udc basis.

OK, I can patch this cleanup seperatly for only the two UDCs that I can
test for now, each on it's own patch.

> The next thing is that
> ep_enable() calls the UDC with arguments while one would be enough.

This is true :-)

>
> Sebatian
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Ido
-- 
Consultant for Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux