[PATCH 0/1] usb: gadget: Update all UDCs to use usb_endpoint_descriptor inside the struct usb_ep

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Since the change "usb: gadget: add usb_endpoint_descriptor to struct usb_ep"
there is a usb_endpoint_descriptor* in the usb_ep struct, however all UDCs keep
using the usb_endpoint_descriptor* inside each UDC wrapper.

This change actually fix a bug:
It appear that some function drivers check if ep.desc is NULL, as happen
in f_serial before calling to config_ep_by_speed. Therefor a bug exists
when disconnecting and reconnecting the usb cable, since on disconnect
the udc does not set the ep.desc to NULL.

This change was tested with ci13xxx_udc and dwc3.
Also tested compilation on all USB modules.

Ido Shayevitz (1):
  usb: gadget: Update all UDCs to use usb_endpoint_descriptor inside
    the struct usb_ep

 drivers/usb/dwc3/core.h             |    1 -
 drivers/usb/dwc3/ep0.c              |    2 +-
 drivers/usb/dwc3/gadget.c           |   32 +++++++++++++++---------------
 drivers/usb/gadget/amd5536udc.c     |   14 ++++++------
 drivers/usb/gadget/amd5536udc.h     |    1 -
 drivers/usb/gadget/at91_udc.c       |   16 +++++++-------
 drivers/usb/gadget/at91_udc.h       |    3 --
 drivers/usb/gadget/atmel_usba_udc.c |   25 ++++++++++++-----------
 drivers/usb/gadget/atmel_usba_udc.h |    1 -
 drivers/usb/gadget/ci13xxx_udc.c    |   16 +++++++-------
 drivers/usb/gadget/ci13xxx_udc.h    |    1 -
 drivers/usb/gadget/fsl_qe_udc.c     |   20 +++++++++---------
 drivers/usb/gadget/fsl_qe_udc.h     |    1 -
 drivers/usb/gadget/fsl_udc_core.c   |   26 ++++++++++++------------
 drivers/usb/gadget/fsl_usb2_udc.h   |    1 -
 drivers/usb/gadget/fusb300_udc.c    |    4 +-
 drivers/usb/gadget/fusb300_udc.h    |    1 -
 drivers/usb/gadget/goku_udc.c       |   21 ++++++++++---------
 drivers/usb/gadget/goku_udc.h       |    1 -
 drivers/usb/gadget/langwell_udc.c   |   36 +++++++++++++++++-----------------
 drivers/usb/gadget/langwell_udc.h   |    1 -
 drivers/usb/gadget/m66592-udc.c     |   10 ++++----
 drivers/usb/gadget/m66592-udc.h     |    2 +-
 drivers/usb/gadget/mv_udc.h         |    1 -
 drivers/usb/gadget/mv_udc_core.c    |   20 +++++++++---------
 drivers/usb/gadget/omap_udc.c       |   20 +++++++++---------
 drivers/usb/gadget/omap_udc.h       |    1 -
 drivers/usb/gadget/pch_udc.c        |   17 +++++++--------
 drivers/usb/gadget/pxa25x_udc.c     |   28 +++++++++++++-------------
 drivers/usb/gadget/pxa25x_udc.h     |    1 -
 drivers/usb/gadget/r8a66597-udc.c   |   14 ++++++------
 drivers/usb/gadget/r8a66597-udc.h   |    2 +-
 drivers/usb/gadget/s3c-hsudc.c      |   11 ++++-----
 drivers/usb/gadget/s3c2410_udc.c    |   16 +++++++-------
 drivers/usb/gadget/s3c2410_udc.h    |    1 -
 35 files changed, 176 insertions(+), 192 deletions(-)

-- 
1.7.6

--
Consultant for Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux