> > On Mon, Jan 30, 2012 at 12:36:12PM +0530, Ramneek Mehresh wrote: > > > Add support for ULPI and UTMI PHYs based on usb controller version > > > info read from device-tree > > > > > > Example of USB Controller versioning info: > > > Version 1.2 and below : MPC8536, MPC8315, etc Version 1.6 : P1020, > > > P1010, P2020, etc Version 2.2 : PSC9131, PSC9132, P3060, etc > > > > > > Signed-off-by: Ramneek Mehresh <ramneek.mehresh@xxxxxxxxxxxxx> > > > --- > > > Changes for v2: > > > - Incorporated Greg's comment > > > - moved fsl_usb.h from drivers/usb/misc > > > to drivers/usb/host/fsl/ > > > > > > drivers/usb/gadget/fsl_udc_core.c | 25 ++++++++++++++- > > > drivers/usb/gadget/fsl_usb2_udc.h | 13 ++++++++ > > > drivers/usb/host/ehci-fsl.c | 35 +++++++++++++++++---- > > > drivers/usb/host/ehci-fsl.h | 15 ++++++++- > > > drivers/usb/host/fsl/fsl_usb.h | 61 > > +++++++++++++++++++++++++++++++++++++ > > > 5 files changed, 141 insertions(+), 8 deletions(-) create mode > > > 100644 drivers/usb/host/fsl/fsl_usb.h > > > > > > diff --git a/drivers/usb/gadget/fsl_udc_core.c > > > b/drivers/usb/gadget/fsl_udc_core.c > > > index d7ea6c0..3c28887 100644 > > > --- a/drivers/usb/gadget/fsl_udc_core.c > > > +++ b/drivers/usb/gadget/fsl_udc_core.c > > Hi ramneek, Freescale i.MX SoCs also use fsl_udc_core.c for device > > function. > > Can you change the patch and let your added code can be not called by > > i.mx SoC? > > Host is ok, as it uses ehci-mxc.c. > > > > [Ramneek]: Hi Peter, the basic thinking behind this patch is that fsl > > usb driver should not be concerned with the SOC. It should only be > > concerned with controller/IP version. This is done to prevent driver > > code contamination with SOC based code/macros. Moving forward, this > > code change will ensure easy code maintainability for fsl usb driver ... > > > > To make this code work for all fsl qoriq and older plarforms, I sent a > > patch for "controller version" information inside all platform device- > > trees. I would recommend the same for i.mx. please let me know if you > > need help for including controller version info for i.mx platforms > > > You mean for all controllers information for i.mx at device-tree file? > I have cc-ed i.mx device-tree guys, I don't know the progress for i.mx > device tree. > > [Ramneek]: Yes Peter, all this collected information was collected from > relevant people, and updated > for qoriq based fsl socs... > Just the version based information needs to be put inside > device-tree. i.mx device-tree guys can > refer to my patch in powerpc branch for this > But currently, as far as I know, the device tree support is incomplete at i.mx, many platforms have no device tree support. Can you add some conditions for device driver/non-device tree, and ppc/arm, some registers don't exist at i.mx soc. FSL ppc and arm uses the same usb controller, but the USB PHYs are different for two platforms. BR, Peter -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
