-----Original Message----- From: Greg KH [mailto:greg@xxxxxxxxx] Sent: Wednesday, January 25, 2012 4:34 AM To: Mehresh Ramneek-B31383 Cc: linux-usb@xxxxxxxxxxxxxxx Subject: Re: [PATCH] fsl/usb:Add controller version based ULPI and UTMI phy support On Wed, Jan 18, 2012 at 07:39:06PM +0530, Ramneek Mehresh wrote: > Add support for ULPI and UTMI PHYs based on usb controller version > info read from device-tree > > Example of USB Controller versioning info: > Version 1.2 and below : MPC8536, MPC8315, etc Version 1.6 : P1020, > P1010, P2020, etc Version 2.2 : PSC9131, PSC9132, P3060, etc > > Signed-off-by: Ramneek Mehresh <ramneek.mehresh@xxxxxxxxxxxxx> > --- > drivers/usb/gadget/fsl_udc_core.c | 25 ++++++++++++++- > drivers/usb/gadget/fsl_usb2_udc.h | 13 ++++++++ > drivers/usb/host/ehci-fsl.c | 35 +++++++++++++++++---- > drivers/usb/host/ehci-fsl.h | 15 ++++++++- > drivers/usb/misc/fsl_usb.h | 61 +++++++++++++++++++++++++++++++++++++ Why are you creating this file, in this directory? If you need to share a .h file, can you put it in include/linux/usb/ or just put it in the host directory and reference that in the gadget directory? Anything but this, this makes no sense. thanks, greg k-h [Ramneek]: Hi Greg, thanks for your input. I didn't put the file in "include/linux/usb/" since this directory contains generic high level headers for USB subsystem. I don't want to start contaminating this directory with PLATFORM specific header files. As regards to putting this file inside host directory, I thought of doing that, but I had my doubts regarding this...about referring a host header file inside gadget stack ... Also, this is strictly fsl specific code that determines usb controller version inside fsl socs. I suggest having a new directory inside "drivers/usb/host/fsl" and putting this file inside it. Later in subsequent patches, we can move all fsl usb code inside this directory. This way we can move all platform specific usb code under appropriate directory. Please suggest... Regards, Ramneek -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
