Marcel Holtmann <marcel@xxxxxxxxxxxx> writes: > why are you bothering with allowing multiple readers. I would just make > the access to this device exclusive. I know that this way you can have > some easy debugging and testing, but at the end of the day there will > only one process controlling this device. Same argumentation as for the > echo support applies here. > > If we just leave this and the echo stuff out of it, you are almost there > with these patches. And then we could focus to actually write some QMI > tools and support to utilize this functionality. Yes. Thanks for the excellent advice. I was in fact already thinking along those lines. So I will rearrange the remaining patches and send an updated version with only the minimum required device-id matching stuff, and maybe a few more non controversion changes (like removing the "i++" in wdm_read :-) as soon as I get some time to do that. Probably won't be until Monday. It might be good to wait and see a few days anyway if there are any other comments which needs to be sorted out, in particular regarding the usbnet implementation. But I realize that getting comments on that will be easier if people can test with it cdc-wdm. After all, you don't really need the usbnet minidriver unless you want to have the cdc-wdm device. The rest of this stuff can always be added later if/when it becomes clean enough. No hurry. Thanks for all your feedback and suggestions. I do really appreciate the time Oliver and you have spent looking at this and trying to make me understand. Bjørn -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
