Re: [PATCH] usb/dummy_hcd: consider stream_id in dummy's enqueue shortcut

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 20 Jan 2012, Sebastian Andrzej Siewior wrote:

> We can ->complete() complete early and we need the stream_id later in
> transfer() so we match against the proper urb.
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> ---
>  drivers/usb/gadget/dummy_hcd.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c
> index 329cc94..f897fb8 100644
> --- a/drivers/usb/gadget/dummy_hcd.c
> +++ b/drivers/usb/gadget/dummy_hcd.c
> @@ -653,6 +653,7 @@ static int dummy_queue(struct usb_ep *_ep, struct usb_request *_req,
>  		memcpy(dum->fifo_buf, _req->buf, _req->length);
>  		req->req.context = dum;
>  		req->req.complete = fifo_complete;
> +		req->req.stream_id = _req->stream_id;

Why is this needed?  req->req.stream_id gets set earlier by the
statement:

		req->req = *_req;

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux