Re: [PATCH 2/2] Revert "xHCI: reset-on-resume quirk for NEC uPD720200"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 01, 2011 at 11:41:23AM -0800, Greg KH wrote:
> On Thu, Dec 01, 2011 at 10:49:47AM -0800, Sarah Sharp wrote:
> > This reverts commit df711fc9962b9491af2b92bd0d21ecbfefe4e5fa.
> > 
> > The commit added a reset-on-resume quirk because the NEC chipset stopped
> > responding to commands about 30 minutes after a system resume from
> > suspend.  We thought it was a chipset issue, but it turns out that the
> > xHCI driver was zeroing out the link TRB after a successful context
> > restore during resume.  The host controller would fall off the command
> > ring sometime later, causing it to not respond to new commands.
> > 
> > The link TRB issue has been fixed with commit
> > 158886cd2cf4599e04f9b7e10cb767f5f39b14f1 "xHCI: fix bug in
> > xhci_clear_command_ring()", so revert the reset-on-resume quirk, as it's
> > not necessary.
> > 
> > Commit df711fc9962b9491af2b92bd0d21ecbfefe4e5fa was marked for stable
> > trees back to 2.6.37, but according to my mail, it has not made it into
> > Linus' tree or the stable trees yet.
> 
> This only made it to my tree so far, and I just noticed that you didn't
> mark it properly for the stable tree, so all should be fine.

Ah, good, ok.  Andiry had the note for stable in his commit message, so
I left it as is.  I suppose I missed the fact that he hadn't Cc'ed
stable@xxxxxxxxxxxxxxx because I was too pleased that he had taken the
time to figure out which stable kernels his bug fix patch applied to. :)

Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux