Re: [PATCH 4/5 v2] usb: renesas_usbhs: fixup ep_disable when no pipe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, Nov 15, 2011 at 04:42:06PM -0800, Kuninori Morimoto wrote:
> > >  1) insmod g_mass_storage.ko
> > >  2) connect cable
> > >  3) disconnect cable
> > 
> > aren't you lacking something here ? Whenever the cable is disconnected,
> > you should signal that to gadget driver so that it has the oportunity to
> > cancel pending transfers and disable endpoints.
> 
> Thank you. this advice taught me the point.  maybe
> af1d7056a5c1e5eaaf807ddd1423101db84668d0 (usb: gadget: renesas:
> convert to new style) seems break cable disconnect method on
> renesas_usbhs.

maybe, but I doubt that's the culprit. When you disconnect a cable, you
should get an interrupt on your driver and your interrupt handler should
call ->disconnect().

now, if you're removing the gadget driver, then there's a bugfix going
upstream for -rc3 right now, Greg just sent a pull request for Linus
containing my fix ;-)

> The issue seems be solved if renesas_usbhs driver call
> driver->disconnect(&gadget) by itself.
> Is this correct ?

it depends where exactly you want to call ->disconnect() :-)

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux