Hi Felipe > > Some USB driver call usb_ep_disable() without calling usb_ep_enable(). > > isn't the fix on "some USB driver" then ? I can take this one in just to > be safe, but I would like to see a WARN_ON_ONCE() so that we catch such > drivers :-) Thank you. I thought it is my drivers side issue. Below is WARN_ON_ONCE() result. I can got it by... 1) insmod g_mass_storage.ko 2) connect cable 3) disconnect cable 4) re-connect cable => WARN renesas_usbhs is supporting runtime connect/disconnect cable. And this error didn't happen on previous kernel. ------------[ cut here ]------------ WARNING: at /opt/usr/src/WORK/morimoto/gitlinux/linux-2.6/drivers/usb/renesas_usbhs/mod_gadget.c:647 usbhsg_ep_disable+0) Modules linked in: g_mass_storage [<c000e138>] (unwind_backtrace+0x0/0xe4) from [<c001a4a4>] (warn_slowpath_common+0x4c/0x64) [<c001a4a4>] (warn_slowpath_common+0x4c/0x64) from [<c001a4d4>] (warn_slowpath_null+0x18/0x1c) [<c001a4d4>] (warn_slowpath_null+0x18/0x1c) from [<c01afaa8>] (usbhsg_ep_disable+0x30/0x58) [<c01afaa8>] (usbhsg_ep_disable+0x30/0x58) from [<bf002590>] (do_set_interface+0xa0/0x2a8 [g_mass_storage]) [<bf002590>] (do_set_interface+0xa0/0x2a8 [g_mass_storage]) from [<bf004a88>] (handle_exception+0x2c4/0x30c [g_mass_stor) [<bf004a88>] (handle_exception+0x2c4/0x30c [g_mass_storage]) from [<bf004b4c>] (fsg_main_thread+0x7c/0x1c4 [g_mass_stora) [<bf004b4c>] (fsg_main_thread+0x7c/0x1c4 [g_mass_storage]) from [<c0030264>] (kthread+0x80/0x88) [<c0030264>] (kthread+0x80/0x88) from [<c000a778>] (kernel_thread_exit+0x0/0x8) ---[ end trace 89fed36ef514e3ad ]--- Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
