Re: [PATCH 4/5 v2] usb: renesas_usbhs: fixup ep_disable when no pipe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 14, 2011 at 11:56:33PM -0800, Kuninori Morimoto wrote:
> 
> Hi Felipe
> 
> > > Some USB driver call usb_ep_disable() without calling usb_ep_enable().
> > 
> > isn't the fix on "some USB driver" then ? I can take this one in just to
> > be safe, but I would like to see a WARN_ON_ONCE() so that we catch such
> > drivers :-)
> 
> Thank you. I thought it is my drivers side issue.
> Below is WARN_ON_ONCE() result.
> I can got it by...
> 
>  1) insmod g_mass_storage.ko
>  2) connect cable
>  3) disconnect cable

aren't you lacking something here ? Whenever the cable is disconnected,
you should signal that to gadget driver so that it has the oportunity to
cancel pending transfers and disable endpoints.

>  4) re-connect cable => WARN

why are you disabling endpoints when you reconnect the cable ?

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux