Hi Heikki,
On Tue, Nov 8, 2011 at 7:25 PM, Heikki Krogerus
<heikki.krogerus@xxxxxxxxxxxxxxx> wrote:
> Introducing struct otg and collecting otg specific members
> to it from struct usb_phy. There are no changes to
> struct usb_phy at this stage. This also renames
> transceiver specific functions, and offers aliases for the
> old otg ones.
>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> ---
> drivers/usb/otg/otg.c | 18 ++++----
> include/linux/usb/otg.h | 96 ++++++++++++++++++++++++++++++++++++++--------
> 2 files changed, 88 insertions(+), 26 deletions(-)
>
> diff --git a/drivers/usb/otg/otg.c b/drivers/usb/otg/otg.c
> index a202e63..c875aff 100644
> --- a/drivers/usb/otg/otg.c
> +++ b/drivers/usb/otg/otg.c
> @@ -18,7 +18,7 @@
> static struct usb_phy *xceiv;
Please replace xceiv to _phy_ in otg utilities as well.
>
> /**
> - * otg_get_transceiver - find the (single) OTG transceiver
> + * usb_get_transceiver - find the (single) OTG transceiver
It should be USB transceiver from now on.
> *
> * Returns the transceiver driver, after getting a refcount to it; or
> * null if there is no such transceiver. The caller is responsible for
> @@ -26,45 +26,45 @@ static struct usb_phy *xceiv;
> *
> * For use by USB host and peripheral drivers.
> */
> -struct usb_phy *otg_get_transceiver(void)
> +struct usb_phy *usb_get_transceiver(void)
> {
> if (xceiv)
> get_device(xceiv->dev);
> return xceiv;
> }
> -EXPORT_SYMBOL(otg_get_transceiver);
> +EXPORT_SYMBOL(usb_get_transceiver);
>
> /**
> - * otg_put_transceiver - release the (single) OTG transceiver
> + * usb_put_transceiver - release the (single) OTG transceiver
same comment here.
> * @x: the transceiver returned by otg_get_transceiver()
it should be usb_get_transceiver :-)
Pls fix the comments section of all the functions in this file.
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
