Hi,
On Thu, Nov 10, 2011 at 05:00:06PM +0530, ABRAHAM, KISHON VIJAY wrote:
> > diff --git a/drivers/usb/otg/otg.c b/drivers/usb/otg/otg.c
> > index a202e63..c875aff 100644
> > --- a/drivers/usb/otg/otg.c
> > +++ b/drivers/usb/otg/otg.c
> > @@ -18,7 +18,7 @@
> > static struct usb_phy *xceiv;
>
> Please replace xceiv to _phy_ in otg utilities as well.
OK
> >
> > /**
> > - * otg_get_transceiver - find the (single) OTG transceiver
> > + * usb_get_transceiver - find the (single) OTG transceiver
>
> It should be USB transceiver from now on.
Agreed.
> > *
> > * Returns the transceiver driver, after getting a refcount to it; or
> > * null if there is no such transceiver. The caller is responsible for
> > @@ -26,45 +26,45 @@ static struct usb_phy *xceiv;
> > *
> > * For use by USB host and peripheral drivers.
> > */
> > -struct usb_phy *otg_get_transceiver(void)
> > +struct usb_phy *usb_get_transceiver(void)
> > {
> > if (xceiv)
> > get_device(xceiv->dev);
> > return xceiv;
> > }
> > -EXPORT_SYMBOL(otg_get_transceiver);
> > +EXPORT_SYMBOL(usb_get_transceiver);
> >
> > /**
> > - * otg_put_transceiver - release the (single) OTG transceiver
> > + * usb_put_transceiver - release the (single) OTG transceiver
> same comment here.
Agreed.
> > * @x: the transceiver returned by otg_get_transceiver()
> it should be usb_get_transceiver :-)
> Pls fix the comments section of all the functions in this file.
Yes, I'll fix these.
Thanks for the review, and sorry about the late reply
--
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
