On 2011-11-03 12:58 -0700, Greg KH wrote: > On Thu, Nov 03, 2011 at 03:53:10PM -0400, Nick Bowler wrote: > > On 2011-11-03 12:34 -0700, Greg KH wrote: > > > On Thu, Nov 03, 2011 at 03:12:45PM -0400, Alan Stern wrote: > > > > I think it doesn't need to be changed. It already says: > > > > > > > > -EPIPE (**) Endpoint stalled. For non-control endpoints, > > > > reset this status with usb_clear_halt(). > > > > > > > > People who are familiar with USB know that control endpoints reply with > > > > a STALL when they don't recognize a request. > > > > > > Well, some of us who are familiar sometimes forget :) > > > > > > I didn't read the whole text, sorry, it was too early in the morning, > > > this patch isn't needed. > > > > OK. However, if we start propagating this error to userspace, users > > who may not be familiar with USB are going to seeing these errors, and > > will need to know that EPIPE here means "throw out your crappy serial > > adaptor". > > Well, if the set command fails, it will get back to userspace who will > know that something is wrong, which is fine. This is true, but we will be introducing a new error condition for tcsendbreak where previously none existed. Users are going to start seeing EPIPE and will need to know what it means. It also seems that userspace apps will also need to be patched to actually _check_ the return value of tcsendbreak (sigh). -- Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/) -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
