Re: [PATCH 1/2] USB: Describe another source of EPIPE in documentation.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 03, 2011 at 03:12:45PM -0400, Alan Stern wrote:
> On Thu, 3 Nov 2011, Nick Bowler wrote:
> 
> > On 2011-11-03 12:10 -0400, Alan Stern wrote:
> > > -EPIPE also means that the control endpoint doesn't recognize the
> > > command it received, which seems quite likely in this case.
> > 
> > Signed-off-by: Nick Bowler <nbowler@xxxxxxxxxxxxxxxx>
> > ---
> >  Documentation/usb/error-codes.txt |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> > 
> > diff --git a/Documentation/usb/error-codes.txt b/Documentation/usb/error-codes.txt
> > index b3f606b..242bc79 100644
> > --- a/Documentation/usb/error-codes.txt
> > +++ b/Documentation/usb/error-codes.txt
> > @@ -42,7 +42,8 @@ USB-specific:
> >  -EFBIG		Host controller driver can't schedule that many ISO frames.
> >  
> >  -EPIPE		The pipe type specified in the URB doesn't match the
> > -		endpoint's actual type.
> > +		endpoint's actual type, or the control endpoint doesn't
> > +		recognize the request.
> >  
> >  -EMSGSIZE	(a) endpoint maxpacket size is zero; it is not usable
> >  		    in the current interface altsetting.
> > 
> 
> No, you have changed the wrong text.  The error codes in this part of 
> the document are those resulting from URB submission.  The code you're 
> interested in is for URB completion.
> 
> I think it doesn't need to be changed.  It already says:
> 
> -EPIPE (**)		Endpoint stalled.  For non-control endpoints,
> 			reset this status with usb_clear_halt().
> 
> People who are familiar with USB know that control endpoints reply with
> a STALL when they don't recognize a request.

Well, some of us who are familiar sometimes forget :)

I didn't read the whole text, sorry, it was too early in the morning,
this patch isn't needed.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux