<tmarri@...> writes:
<snip>
> +void dwc_otg_enable_global_interrupts(struct core_if *core_if)
> +{
> + u32 ahbcfg = 0;
> +
> + ahbcfg |= DWC_AHBCFG_GLBL_INT_MASK;
> + dwc_reg_modify(core_if->core_global_regs, DWC_GAHBCFG, 0,
> + ahbcfg);
What is the point of initializing the variable to 0, and then immediately
ORing it with a value? Why not just:
u32 ahbcfg = DWC_AHBCFG_GLBL_INT_MASK;
dwc_reg_modify(core_if->core_global_regs, DWC_GAHBCFG,
ahbcfg, 0);
or even simpler:
dwc_reg_modify(core_if->core_global_regs, DWC_GAHBCFG,
DWC_AHBCFG_GLBL_INT_MASK, 0);
? Same for other places in this file.
> +/**
> + * Tests if the current hardware is using a full speed phy.
> + */
> +static inline int full_speed_phy(struct core_if *core_if)
> +{
> + if ((DWC_HWCFG2_FS_PHY_TYPE_RD(core_if->hwcfg2) == 2 &&
> + DWC_HWCFG2_FS_PHY_TYPE_RD(core_if->hwcfg2) == 1 &&
Surely this is a typo? You are checking the same variable for containing
two different values at the same time. From looking at similar code in
the dwc_otg_core_init() function, I think you meant to write:
if ((DWC_HWCFG2_HS_PHY_TYPE_RD(core_if->hwcfg2) == 2 &&
DWC_HWCFG2_FS_PHY_TYPE_RD(core_if->hwcfg2) == 1 &&
--
Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
