Re: [PATCH v14 01/10] USB/ppc4xx: Add Synopsys DesignWare HS USB OTG Register definitions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



 <tmarri@...> writes:

> From: Tirumala Marri <tmarri-qTEPVZfXA3Y <at> public.gmane.org>

<snip>

> +#define DWC_GCTL_BSESSION_VALID_RD(reg)	(((reg) & (0x001 << 19)) >> 19)

This seems a rather odd way to do the mask and shift. Why not just do:

	(((reg) >> 19) & 0x001)

? Same for many other places in this file.

-- 
Paul


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux