Hi, On Mon, Sep 05, 2011 at 04:48:36PM +0200, Sebastian Andrzej Siewior wrote: > >then, let's say ehci-tegra populates that... on ehci_probe() > >(ehci-hcd.c::probe), we could have: > > > >... > > > >ehci->ops = pdev->dev.platform_data; > > I know where you go with this but as of now we can't do this because > usb_add_hcd() allocates the ehci struct. sure, and that is also something else that should probably change. > >See that ehci-tegra, would only pass the fields which it needs and if > >the pointer is NULL the default/generic implementations are used, > >because it's assumed that this particular architecture doesn't need > >anything different from what the standard says. > > I see. So ehci_platform_ops would contain all elements from hc_driver it doesn't to contain all elements either. We just need, as of today, to cope with the most "interesting" architecture we have so far. If that means we need 5 callbacks, then we add 5 callbacks. If in the future we need more, it's easy to patch it up. -- balbi
Attachment:
signature.asc
Description: Digital signature
