On 08/25/2011 11:33 PM, Felipe Balbi wrote:
Hi again,
Hi there,
love. The remaining part where you do register, obtain memory address,
get irq, register hcd and so on is nearly identical. So right now I
think it can be merged :)
While it might possible to merge them. I think we should take smaller
steps at a time. Those files are already there anyway. So at first we
find a way to clean up the ifdeferry and allow all of those to be built
on all archs (it's definitely possible) so linux-next can catch more
compile errors for us, then we start combining the common part: move
hc_driver to ehci-hcd.c, make all ehci_* symbols static, add pm_runtime
support to avoid explicit clock initialization, figure out how to split
platform-specific from HCI specific, etc etc.
IMHO, if we start by combining ehci-<arch>.c files into one single
thing, it'll be really messy.
You think so? I will see and find out. As I said, 90% of the probe
function is the same thing over and over. The PCI-class of controllers
do have a common function for this, the rest of the world does not.
So would try to factor this pieces and group them together.
The reset callback is almost the story: most of them do the same thing.
But okay. So let me first get rid of the if fairy and then merge some
code.
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
