Hi again, (forgot one comment) On Thu, Aug 25, 2011 at 09:31:24PM +0200, Sebastian Andrzej Siewior wrote: [snip] > love. The remaining part where you do register, obtain memory address, > get irq, register hcd and so on is nearly identical. So right now I > think it can be merged :) While it might possible to merge them. I think we should take smaller steps at a time. Those files are already there anyway. So at first we find a way to clean up the ifdeferry and allow all of those to be built on all archs (it's definitely possible) so linux-next can catch more compile errors for us, then we start combining the common part: move hc_driver to ehci-hcd.c, make all ehci_* symbols static, add pm_runtime support to avoid explicit clock initialization, figure out how to split platform-specific from HCI specific, etc etc. IMHO, if we start by combining ehci-<arch>.c files into one single thing, it'll be really messy. -- balbi
Attachment:
signature.asc
Description: Digital signature
