Hi Sifram,
This patch doesn't apply against the 3.0.3 tag:
sarah@xanatos:~/git/kernels/xhci$ git am -s ~/Maildir.fetchmail/.to-apply/
Applying: xhci: Redundant check in xhci_check_args
error: patch failed: drivers/usb/host/xhci.c:945
error: drivers/usb/host/xhci.c: patch does not apply
Patch failed at 0001 xhci: Redundant check in xhci_check_args
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".
Looking at the raw form of your mail, your email client seems to have
turned tabs into spaces. Did you copy-paste the patch or use the gmail
web interface? That often converts tabs to spaces. I would suggest you
use mutt to send your messages, or another mail client mentioned in
Documentation/email-clients.txt
Sarah Sharp
[1] git clone -b for-usb-next git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git
On Wed, Aug 24, 2011 at 02:11:51AM +0530, sifram rajas wrote:
> In the xhci_check_args() function in xhci.c, there is a redundant
> check for xhci->devs.
>
> This is redundant because the struct xhci_hcd->devs is actually
> defined as a static array
> of pointers and is not a pointer to a pointer.
>
> Signed-off-by: Sifram Rajas <sifram.rajas@xxxxxxxxx>
> ---
> diff -uprN a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> --- a/drivers/usb/host/xhci.c 2011-08-17 23:27:16.000000000 +0530
> +++ b/drivers/usb/host/xhci.c 2011-08-22 20:43:34.250000000 +0530
> @@ -945,8 +945,7 @@ static int xhci_check_args(struct usb_hc
> return -ENODEV;
>
> if (check_virt_dev) {
> - if (!udev->slot_id || !xhci->devs
> - || !xhci->devs[udev->slot_id]) {
> + if (!udev->slot_id || !xhci->devs[udev->slot_id]) {
> printk(KERN_DEBUG "xHCI %s called with unaddressed "
> "device\n", func);
> return -EINVAL;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
