On Thu, 25 Aug 2011, Sarah Sharp wrote:
> > > + } else {
> > > + if (portchange & USB_PORT_STAT_C_BH_RESET) {
> > > + clear_port_feature(hub->hdev, port1,
> > > + USB_PORT_FEAT_C_BH_PORT_RESET);
> > > +
> > > + if (portchange & USB_PORT_STAT_C_LINK_STATE)
> > > + clear_port_feature(hub->hdev, port1,
> > > + USB_PORT_FEAT_C_PORT_LINK_STATE);
> > > +
> >
> > Why do you need to clear these features specially for a warm reset?
> > Can't they be cleared the same way as USB_PORT_FEAT_C_RESET?
>
> I don't understand your question. Are you trying to say that the xHCI
> host controller should clear the BH reset connect change when the USB
> core asks it to clear the RESET change? Or are you suggesting something
> else?
I meant it's weird to see those two clear_port_feature() calls sitting
by themselves like that. They should occur along with the
clear_port_feature for C_RESET; all the status-change features should
be cleared in the same place in the code.
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
