In the xhci_check_args() function in xhci.c, there is a redundant
check for xhci->devs.
This is redundant because the struct xhci_hcd->devs is actually
defined as a static array
of pointers and is not a pointer to a pointer.
Signed-off-by: Sifram Rajas <sifram.rajas@xxxxxxxxx>
---
diff -uprN a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
--- a/drivers/usb/host/xhci.c 2011-08-17 23:27:16.000000000 +0530
+++ b/drivers/usb/host/xhci.c 2011-08-22 20:43:34.250000000 +0530
@@ -945,8 +945,7 @@ static int xhci_check_args(struct usb_hc
return -ENODEV;
if (check_virt_dev) {
- if (!udev->slot_id || !xhci->devs
- || !xhci->devs[udev->slot_id]) {
+ if (!udev->slot_id || !xhci->devs[udev->slot_id]) {
printk(KERN_DEBUG "xHCI %s called with unaddressed "
"device\n", func);
return -EINVAL;
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
