Re: [RFC PATCHv2 00/17] First round in OTG rework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Heikki,

On Tue, Aug 16, 2011 at 01:09:30PM +0300, Heikki Krogerus wrote:
> Hi guys,
> 
> So this would the first step where otg_transceiver is first renamed to
> usb_transceiver and OTG stuff is separated into new structure, struct
> otg.

That's a good step into the right direction. Now people with a USB phy
but without interest in otg find themselves in the code.

> I would have preferred introducing the new things separately
> without touching the existing and letting driver maintainers to start
> using them in their own time, but if this is the way it should be
> done, then here you go.
> 
> The First two patches rename otg_transceiver and introduce struct otg.
> The otg/transceiver drivers are converted each in it's own patch, but
> the users are converted in singe patches, first to change the
> transceiver specific function names and then to pass the struct otg
> instead of usb_transceiver to otg_* functions.
> 
> The naming needs to be decided. usb_transceiver is indeed a long name,
> but I'm not completely happy with usb_xceiv name. I would prefer
> usb_phy.

I'm fine with both usb_transceiver and usb_phy, but please no usb_xceiv
as it is hard to remember. What was it again, usb_xceiv, usb_xcv or even
usb_xceiver?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux