RE: [PATCH] usb/xhci: add module license for xhci-pci glue code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



-----Original Message-----
> From: Felipe Balbi [mailto:balbi@xxxxxx] 
>
> > > On Thu, Jul 28, 2011 at 10:25:06AM +0200, Sebastian Andrzej Siewior wrote:
> > > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> > > > ---
> > > > * Paul Zimmerman | 2011-07-27 23:18:03 [+0000]:
> > > > >Any ideas?
> > > > Yes, this should fix this.
> > > > 
> > > >  drivers/usb/host/xhci-pci.c |    2 ++
> > > >  1 files changed, 2 insertions(+), 0 deletions(-)
> > > > 
> > > > diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> > > > index a73b332..2baa2cc 100644
> > > > --- a/drivers/usb/host/xhci-pci.c
> > > > +++ b/drivers/usb/host/xhci-pci.c
> > > > @@ -253,3 +253,5 @@ static void xhci_unregister_pci(void)
> > > >  	pci_unregister_driver(&xhci_pci_driver);
> > > >  }
> > > >  module_exit(xhci_unregister_pci);
> > > > +MODULE_DESCRIPTION("PCI glue code for the XHCI controller");
> > > > +MODULE_LICENSE("GPL v2");
> > >
> > > aha, good catch :-)
> > 
> > Yes, it loads now, and then immediately crashes the kernel :)
> > 
> > Screenshot at http://minus.com/mdYk7ze
>
> that's definitely a screenshot :-)
> 
> hmm.. it's stopping in __pci_bus_find_cap_start()... Do you still have
> vmlinux with debugging for that kernel ? If you do then what do you get
> when you run the below:
>
> $ gdm vmlinux
> (gdb) l *(__pci_bus_find_cap_start + 0x1e)
>
> ???

(gdb) l *(__pci_bus_find_cap_start + 0x1e)
0xffffffff81239245 is in __pci_bus_find_cap_start (/home/lab/git/xhci-sarah/drivers/pci/pci.c:196).
191	{
192		u16 status;
193	
194		pci_bus_read_config_word(bus, devfn, PCI_STATUS, &status);
195		if (!(status & PCI_STATUS_CAP_LIST))
196			return 0;
197	
198		switch (hdr_type) {
199		case PCI_HEADER_TYPE_NORMAL:
200		case PCI_HEADER_TYPE_BRIDGE:

(gdb) l *(pci_bus_read_config_dword + 0x57)
0xffffffff81237002 is in pci_bus_read_config_dword (/home/lab/git/xhci-sarah/drivers/pci/access.c:58).
53		return res;							\
54	}
55	
56	PCI_OP_READ(byte, u8, 1)
57	PCI_OP_READ(word, u16, 2)
58	PCI_OP_READ(dword, u32, 4)
59	PCI_OP_WRITE(byte, u8, 1)
60	PCI_OP_WRITE(word, u16, 2)
61	PCI_OP_WRITE(dword, u32, 4)
62	
(gdb)

A bad value for 'bus' or 'devfn' I guess?

Unfortunately I won't be able to spend any more time on this today,
and next week I am on vacation.

You should think about getting your own xhci card for your PC. You
can find them on the internet. In fact, I think TI makes one :)

-- 
Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux