On Thu, 7 Jul 2011, Boris Todorov wrote: > Hi Alan, > > I see that you are the maintainer of linux-usb (or I'm wrong??). > I sent a simple patch for EHCI some days ago (my first patch ever for > linux-usb) and I wanted to ask: Is there some way to know if my patch > is NACK/ACK? I mean if nobody answered does this mean that it's OK or > just nobody cared to see it? > Sorry to bother you with stupid questions but can't find any info about it. Sorry, I have been busy with other things and haven't had time to look at your submission. > On Fri, Jun 24, 2011 at 5:42 PM, Boris Todorov > <boris.st.todorov@xxxxxxxxx> wrote: > > The sequence to put port in test mode is not complete. > > According EHCI specification the enabled ports must be > > put in suspend by setting PORTSC.Suspend=1. True. But your patch puts only the port being tested into suspend mode, whereas the spec seems to say that _all_ enabled ports must be suspended. > > Signed-off-by: Boris Todorov <boris.st.todorov@xxxxxxxxx> > > --- > > �drivers/usb/host/ehci-hub.c | � �3 +++ > > �1 files changed, 3 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c > > index ea6184b..e608a80 100644 > > --- a/drivers/usb/host/ehci-hub.c > > +++ b/drivers/usb/host/ehci-hub.c > > @@ -1120,6 +1120,9 @@ static int ehci_hub_control ( > > � � � � � � � � � � � �if (!selector || selector > 5) > > � � � � � � � � � � � � � � � �goto error; > > � � � � � � � � � � � �ehci_quiesce(ehci); > > + � � � � � � � � � � � ehci_writel(ehci, > > + � � � � � � � � � � � � � � � ehci_readl(ehci, status_reg)|PORT_SUSPEND, > > + � � � � � � � � � � � � � � � status_reg); > > � � � � � � � � � � � �ehci_halt(ehci); > > � � � � � � � � � � � �temp |= selector << 16; > > � � � � � � � � � � � �ehci_writel(ehci, temp, status_reg); Apart from that, this seems okay. I never use the port test modes, and I doubt very many other people do, so this code hasn't had a lot of testing. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
