Hi Sebastian, Thank you for your comment. 2011/07/07 17:11, Sebastian Andrzej Siewior wrote: > * Yoshihiro Shimoda | 2011-07-07 09:57:46 [+0900]: > >> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > > Is this a regression to what I did or was this always there? This issue was always there. >> diff --git a/drivers/usb/gadget/r8a66597-udc.c b/drivers/usb/gadget/r8a66597-udc.c >> index fb707bb..1115647 100644 >> --- a/drivers/usb/gadget/r8a66597-udc.c >> +++ b/drivers/usb/gadget/r8a66597-udc.c >> @@ -1456,6 +1456,7 @@ static int r8a66597_start(struct usb_gadget_driver *driver, >> goto error; >> } >> >> + init_controller(r8a66597); > > This is already done on ->stop() and this is called on rmmod. In case > you plan to keep this on in ->start() is it also required to keep a call > of this in ->stop() and probe? > Yes, I do. But, I felt that this is a strange code... I will clean up the code. Best regards, Yoshihiro Shimoda -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
