* Yoshihiro Shimoda | 2011-07-07 09:57:46 [+0900]:
>Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
Is this a regression to what I did or was this always there?
>diff --git a/drivers/usb/gadget/r8a66597-udc.c b/drivers/usb/gadget/r8a66597-udc.c
>index fb707bb..1115647 100644
>--- a/drivers/usb/gadget/r8a66597-udc.c
>+++ b/drivers/usb/gadget/r8a66597-udc.c
>@@ -1456,6 +1456,7 @@ static int r8a66597_start(struct usb_gadget_driver *driver,
> goto error;
> }
>
>+ init_controller(r8a66597);
This is already done on ->stop() and this is called on rmmod. In case
you plan to keep this on in ->start() is it also required to keep a call
of this in ->stop() and probe?
> r8a66597_bset(r8a66597, VBSE, INTENB0);
> if (r8a66597_read(r8a66597, INTSTS0) & VBSTS) {
> r8a66597_start_xclock(r8a66597);
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
