Re: [PATCH 06/41] usb: gadget: add max_speed to usb_composite_driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 29 Jun 2011, Jassi Brar wrote:

> >> IMHO Gadget drivers need not be specified at _compile_ time if they
> >> could be used over high speed UDC. The gadget drivers should simply
> >> support HS descriptors too and decide at runtime if they need to use them.
> >
> > Why?
> >
> > If you're building an embedded system with limited memory, and you know
> > the UDC on that system isn't capable of running at high speed, why
> > should the gadget driver include HS descriptors?
> >
> Because
> a) We can(do already?) tag descriptors __initdata

Not in all the function drivers (I'm thinking especially of
f_sourcesink and f_loopback, but there are others).  Let's fix those up
first.

Also, what about printer.c and inode.c?  They don't even use the
composite framework.  Although I guess it doesn't matter so much if the 
two of them always allow HS operation...

> b) Esp when we talk about enabling gadget stack to play nice for embedded linux
> distributions, I doubt if any distribution would compile any gadget
> driver without
> CONFIG_USB_GADGET_DUALSPEED.

I wasn't referring to distributions but to individual projects.

When all the gadget and function drivers have been converted to use
__initdata for their descriptors, I'll support getting rid of 
CONFIG_USB_GADGET_DUALSPEED.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux