On Wed, 29 Jun 2011, Kirill Smelkov wrote: > > Apart from that one issue, > > > > Acked-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> > > Thanks. > > What should we do with this patch now? Should I put > > > Copyright (C) 2007 by Alan Stern > > there? Or something else? Yes, put that in. > Or maybe drop that copyright notice altogether becase usually it gets > outdated very quickly, and who made what is visible through git > log/blame? Copyright information is important, and it must be present in the actual file -- not somewhere else (such as a changelog). > I'm ok with any case, please just tell me how to proceed. > > > And what about main "[PATCH v2 2/2] USB: EHCI: Allow users to override > 80% max periodic bandwidth"? > > Was it Acked together with this one, or not and review is pending? > Curious because I'm new here... I haven't taken the time to review it yet, sorry... Mostly it looks okay. In store_uframe_periodic_max(), you can use kstrtouint() instead of sscanf() -- that seems to be the trend these days. Also, when decreasing the schedule limit, do you think it is really necessary to check that the current allocation doesn't exceed the new limit? I think it would be sufficient to apply the new limit just to new bandwidth allocation requests. After all, this API is meant for experts only. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
