Re: [Question] dummy_hcd and FS devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 1 Jun 2011, Tanya Brokhman wrote:

> Hi Sarah, Alan,
> 
> I was trying to enumerate a FS device using dummy_hcd but unfortunately it
> didn't work. The enumeration failed because "parent hub has no TT". I
> searched the code and saw that the hub->tt.hub is set if bDeviceProtocol=1,
> when according to usb2_rh_dev_descriptor (defined in hcd.c)
> bDeviceProtocol=0, meaning, no TT.

I thought a fix for this had been sent in, but apparently not.

> So I have 2 questions:
> 1. Was dummy_hcd ever tested with FS devices?

I don't know.  In fact, I'm not sure whether we have any 
full-speed-only gadget drivers.

> 2. How this is working for a real HS root hub? I'm sorry for asking this,
> but I didn't find it in the code and we don't have any convenient tools for
> host debugging so it's not so trivial. 

The fix is indeed trivial.  I'll submit this to Greg shortly, but you 
can start using it now.

Alan Stern


 drivers/usb/gadget/dummy_hcd.c |    1 +
 1 file changed, 1 insertion(+)

Index: usb-3.0/drivers/usb/gadget/dummy_hcd.c
===================================================================
--- usb-3.0.orig/drivers/usb/gadget/dummy_hcd.c
+++ usb-3.0/drivers/usb/gadget/dummy_hcd.c
@@ -1906,6 +1906,7 @@ static int dummy_hcd_probe(struct platfo
 	if (!hcd)
 		return -ENOMEM;
 	the_controller = hcd_to_dummy (hcd);
+	hcd->has_tt = 1;
 
 	retval = usb_add_hcd(hcd, 0, 0);
 	if (retval != 0) {

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux