> -----Original Message----- > From: linux-usb-owner@xxxxxxxxxxxxxxx [mailto:linux-usb- > owner@xxxxxxxxxxxxxxx] On Behalf Of Maarten Lankhorst > Sent: Monday, May 30, 2011 5:57 PM > To: linux-usb@xxxxxxxxxxxxxxx > Cc: Sarah Sharp; linux-kernel@xxxxxxxxxxxxxxx; Maarten Lankhorst > Subject: [PATCH] [RFC] usb: Broaden range of vendor codes for xhci > > My asrock P67 chipset sends code 192 on device reset. Allowing >= 192 > to be treated as success fixes it, and allows me to use my USB3 port. > TRB completion code 192-223 is defined as Vendor defined error. Your host controller returns a error - don't know what causes the error since it's vendor defined. > Signed-off-by: Maarten Lankhorst <m.b.lankhorst@xxxxxxxxx> > > --- > There still appears to be a possible regression though. I can't > currently use my usb headset, but since my xhci port never worked, I > can't tell for sure if it ever worked. > > Resending, forgot to add relevant maintainers. > --- > drivers/usb/host/xhci-ring.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci- > ring.c > index 7437386..f8b9f79 100644 > --- a/drivers/usb/host/xhci-ring.c > +++ b/drivers/usb/host/xhci-ring.c > @@ -1464,7 +1464,7 @@ static int > xhci_requires_manual_halt_cleanup(struct xhci_hcd *xhci, > > int xhci_is_vendor_info_code(struct xhci_hcd *xhci, unsigned int > trb_comp_code) > { > - if (trb_comp_code >= 224 && trb_comp_code <= 255) { > + if (trb_comp_code >= 192 && trb_comp_code <= 255) { > /* Vendor defined "informational" completion code, > * treat as not-an-error. > */ > -- You may need to create another function, maybe xhci_is_vendor_error_code(), because trb_comp_code between 192-223(Vendor Defined Error) and 224-255 (Vendor defined Info) has different meanings. Thanks, Andiry > 1.7.4.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
