On Sunday 24 April 2011 17:29:16 Greg KH wrote: > On Sun, Apr 24, 2011 at 05:19:12PM +0200, Marius Kotsbak wrote: > > Den 24. april 2011 16:30, skrev Hans Petter Selasky: > > >>But I do need a signed-off-by line for this. > > > > > >What should I put as signed-off-by ? > > > > Add this flag to the git commit command: > > > > -s, --signoff > > > > Add Signed-off-by line by the committer at the end of the > > > > commit log message. > > > > (use --amend / rebase -i to add it to an existing commit) > > That's one way of doing it, but I think the original question is "what" > is a signed-off-by line, which is more important. > > Hans, see the file in the kernel source tree, > Documentation/SubmittingPatches for details as to what you are agreeing > with when adding your signed-off-by to a patch. That should explain > it in detail, and if you have any further questions about it, please let > us know. Hi, Got it! I also tried to fix the line-wrapping of the commit message. See attachment. --HPS
From 32b84c3cfc7d82cb27b31255ed63bc8bb0e15262 Mon Sep 17 00:00:00 2001 From: Hans Petter Selasky <hselasky@xxxxxxx> Date: Sat, 23 Apr 2011 19:20:41 +0200 Subject: [PATCH] The default maximum transmit length for NCM USB frames should be so that a short packet happens at the end if the device supports a length greater than the defined maximum. This is achieved by adding 4 bytes to the maximum length so that the existing logic can fit a short packet there. Signed-off-by: Hans Petter Selasky <hselasky@xxxxxxx> --- drivers/net/usb/cdc_ncm.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c index 967371f..1033ef6 100644 --- a/drivers/net/usb/cdc_ncm.c +++ b/drivers/net/usb/cdc_ncm.c @@ -54,13 +54,13 @@ #include <linux/usb/usbnet.h> #include <linux/usb/cdc.h> -#define DRIVER_VERSION "7-Feb-2011" +#define DRIVER_VERSION "23-Apr-2011" /* CDC NCM subclass 3.2.1 */ #define USB_CDC_NCM_NDP16_LENGTH_MIN 0x10 /* Maximum NTB length */ -#define CDC_NCM_NTB_MAX_SIZE_TX 16384 /* bytes */ +#define CDC_NCM_NTB_MAX_SIZE_TX (16384 + 4) /* bytes, must be short terminated */ #define CDC_NCM_NTB_MAX_SIZE_RX 16384 /* bytes */ /* Minimum value for MaxDatagramSize, ch. 6.2.9 */ -- 1.7.1.1
