> > @@ -775,7 +774,7 @@ int __init audio_bind_config(struct > usb_configuration *c) > > audio->card.func.set_alt = f_audio_set_alt; > > audio->card.func.setup = f_audio_setup; > > audio->card.func.disable = f_audio_disable; > > - audio->out_desc = &as_out_ep_desc; > > + audio->out_ep->desc = &as_out_ep_desc; > > I guess you didn't test the audio gadget with this patch? This last > change > causes a NULL pointer dereference, because 'audio' was allocated in > this > function, and nothing has set the 'out_ep' pointer yet. We did some really basic tests to all the gadget drivers like loading the gadget but I'll look into the audio gadget once more. It's holidays in Israel so I'll be back to the office on the 26.04. I'll verify this and get back to you. Thanks! > Also, why do you submit the patch series with different version numbers > on each patch? I find that confusing. The normal way it's done is to > bump the version number on every patch in the series, even if some of > them have not changed. That's my mistake, sorry. I thought that the version number shouldn't be updated if the patch didn't change. I'll keep this in mind when I upload patches in the future. Thank you! Best regards, Tanya Brokhman Consultant for Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
