RE: [PATCH/RESEND v6 2/6] usb: Add usb_endpoint_descriptor to be part of the struct usb_ep

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Paul

> > @@ -775,7 +774,7 @@ int __init audio_bind_config(struct
> usb_configuration *c)
> >  	audio->card.func.set_alt = f_audio_set_alt;
> >  	audio->card.func.setup = f_audio_setup;
> >  	audio->card.func.disable = f_audio_disable;
> > -	audio->out_desc = &as_out_ep_desc;
> > +	audio->out_ep->desc = &as_out_ep_desc;
> 
> I guess you didn't test the audio gadget with this patch? This last
> change
> causes a NULL pointer dereference, because 'audio' was allocated in
> this
> function, and nothing has set the 'out_ep' pointer yet.

You're right in your observation. This needs to be fixed. Somehow we missed
testing the audio gadget so thanks for catching this!
I'll make the fix in the next version.


Best regards,
Tanya Brokhman
Consultant for Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum




--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux