Re: patch "usb: usb_storage: do not align length of request for CBW to maxp size" added to usb tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 14, 2011 at 05:39:18PM +0200, Mian Yousaf Kaukab wrote:
> On 04/14/2011 05:31 PM, Alan Stern wrote:
> >On Wed, 13 Apr 2011 gregkh@xxxxxxx wrote:
> >> From 806e8f8fcc27e1753947bd9f059ba2316cf8f92a Mon Sep 17 00:00:00 2001
> >>From: Mian Yousaf Kaukab<mian.yousaf.kaukab@xxxxxxxxxxxxxx>
> >>Date: Thu, 24 Mar 2011 12:20:13 +0100
> >>Subject: usb: usb_storage: do not align length of request for CBW to maxp size
> >The necessity for this patch has been under discussion.
> >
> >It turns out the UDC that Mian has been working on and Felipe's UDC
> >have contradictory requirements.  Mian's UDC driver wants a bulk-OUT
> >transfer length to be shorter than the maxpacket size if a short packet
> >is expected, whereas Felipe's UDC hardware always needs bulk-OUT
> >transfer lengths to be evenly divisible by the maxpacket size.
> >
> >Mian has agreed to go back over the driver to resolve this conflict.
> >This means we probably will not want this patch after all.  (In fact,
> >we may ultimately decide to change the gadget framework to require that
> >bulk-OUT transfer lengths _always_ be divisible by the maxpacket size
> >-- only the g_file_storage and g_mass_storage gadgets would need to be
> >changed.)
> >
> >Mian, should Greg revert this patch now?  I think we will want to
> >revert it eventually...
> Yes sure. Greg please drop this one.

Ok, thanks for letting me know, it's now reverted.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux