On Thu, Apr 14, 2011 at 04:12:34PM -0400, Elly Jones wrote: > > > +#define IOCTL_QMI_GET_SERVICE_FILE (0x8BE0 + 1) > > > +#define IOCTL_QMI_GET_DEVICE_VIDPID (0x8BE0 + 2) > > > +#define IOCTL_QMI_GET_DEVICE_MEID (0x8BE0 + 3) > > > +#define IOCTL_QMI_CLOSE (0x8BE0 + 4) > > > +#define CDC_GET_ENCAPSULATED_RESPONSE 0x01A1ll > > > +#define CDC_CONNECTION_SPEED_CHANGE 0x08000000002AA1ll > > > > We have IOR/IOW/etc macros for building ioctl numbers and it should be > > using those. To start with that helps enormously for trace tools as it > > shows the directions and sizes in the ioctl code. > > These ioctl numbers have to stay the same in order to remain compatible with a > closed userspace SDK that we can't change. Why can't we change them? We have contacts in qualcomm and they should work to support modemmanager properly for this device. All of the above looks like things we don't want in the in-kernel driver anyway, right? There's no requirement to support the closed userspace tool here, is there? If so, who is making that requirement? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
