Re: [PATCH] musb: add double buffer flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, Jan 21, 2011 at 01:39:20PM +0800, Bob Liu wrote:
> diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
> index 4d5bcb4..7a9ab45 100644
> --- a/drivers/usb/musb/musb_host.c
> +++ b/drivers/usb/musb/musb_host.c
> @@ -609,7 +609,7 @@ musb_rx_reinit(struct musb *musb, struct musb_qh *qh, struct musb_hw_ep *ep)
>  	/* Set RXMAXP with the FIFO size of the endpoint
>  	 * to disable double buffer mode.
>  	 */
> -	if (musb->hwvers < MUSB_HWVERS_2000)
> +	if (musb->double_buffer_not_ok)
>  		musb_writew(ep->regs, MUSB_RXMAXP, ep->max_packet_sz_rx);
>  	else
>  		musb_writew(ep->regs, MUSB_RXMAXP,

you're only changing RX path, does double buffering work on TX path ?
This patch seems incomplete for host side. My original version was
changing both RX and TX.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux