On Fri, Jan 21, 2011 at 2:25 PM, Felipe Balbi <balbi@xxxxxx> wrote: > Hi, > > On Fri, Jan 21, 2011 at 01:39:20PM +0800, Bob Liu wrote: >> diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c >> index 4d5bcb4..7a9ab45 100644 >> --- a/drivers/usb/musb/musb_host.c >> +++ b/drivers/usb/musb/musb_host.c >> @@ -609,7 +609,7 @@ musb_rx_reinit(struct musb *musb, struct musb_qh *qh, struct musb_hw_ep *ep) >> Â Â Â /* Set RXMAXP with the FIFO size of the endpoint >> Â Â Â Â* to disable double buffer mode. >> Â Â Â Â*/ >> - Â Â if (musb->hwvers < MUSB_HWVERS_2000) >> + Â Â if (musb->double_buffer_not_ok) >> Â Â Â Â Â Â Â musb_writew(ep->regs, MUSB_RXMAXP, ep->max_packet_sz_rx); >> Â Â Â else >> Â Â Â Â Â Â Â musb_writew(ep->regs, MUSB_RXMAXP, > > you're only changing RX path, does double buffering work on TX path ? > This patch seems incomplete for host side. My original version was > changing both RX and TX. > Oh, I just replaced origin positions where have "MUSB_HWVERS_2000". But I agree with changing TX path also. -- Regards, --Bob -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
