Re: [PATCH] musb: add double buffer flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 21, 2011 at 2:16 PM, Felipe Balbi <balbi@xxxxxx> wrote:
> Hi,
>
> On Fri, Jan 21, 2011 at 01:39:20PM +0800, Bob Liu wrote:
>> As blackfin doesn't support double buffering feature as of today.
>> It used to use
>> Commit 9f445cb [USB: musb: disable double buffering for older RTL versions] to
>> skip this problem, but which caused other problem.
>> eg: As Ajay pointed out "breaking the high bandwidth isochronous transfer" and
>> Ming pointed "break full speed and cause overflow problems".
>>
>> So add a flag set by musb_platform_init() to force fully disable that feature.
>> Such flag is created and marked as deprecated to force to find a solution for
>> the missing double buffering support on blackfin.
>>
>> Signed-off-by: Bob Liu <lliubbo@xxxxxxxxx>
>
> I believe this is basically the patch I sent earlier ?
>
> http://marc.info/?l=linux-usb&m=129075554325837&w=2
>
> You can't simply take the patch and claim it's yours. I didn't apply it
> because I haven't tested it. If you tell me it's working on blackfin,
> I'll use my own (original) version, but I need to be sure it's not
> breaking DaVinci either.
>

Oh, Yes, it's based on your patch although I made some changes.
I am sorry for forgetting to describe that.
It works okay on blackfin arch.

-- 
Thanks,
--Bob
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux