Hello. On 06-01-2011 19:33, Sarah Sharp wrote:
Make sure to call into the USB core's link, unlink, and giveback URB functions with the usb_hcd pointer found by using urb->dev->bus. This will avoid confusion later, when the xHCI driver will deal with URBs from two separate buses (the USB 3.0 roothub and the faked USB 2.0 roothub).
Assume xhci_urb_dequeue() will be called with the proper usb_hcd.
Signed-off-by: Sarah Sharp<sarah.a.sharp@xxxxxxxxxxxxxxx>
[...]
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index 6abe2e9..0a58be8 100644 --- a/drivers/usb/host/xhci-ring.c +++ b/drivers/usb/host/xhci-ring.c @@ -599,13 +599,14 @@ static inline void xhci_stop_watchdog_timer_in_irq(struct xhci_hcd *xhci, static void xhci_giveback_urb_in_irq(struct xhci_hcd *xhci, struct xhci_td *cur_td, int status, char *adjective) { - struct usb_hcd *hcd = xhci_to_hcd(xhci); + struct usb_hcd *hcd;
Perhaps time to align with below variables?
I never align variables with tabs.
Hm, I thought xHCI driver is your code...
I don't like the fact that if you introduce a new variable with a longer type, you have to re-align all the other variable declarations. It produces noise in the diff stats that make it hard to pick out what really changed.
I'd agree with you.
CodingStyle says nothing about aligning variables, so why bring it up when the style of the driver isn't to align them?
I have no idea about the style of the driver overall; I could only judge by the style used in this very function.
Sarah Sharp
WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
