On Thu, Jan 06, 2011 at 03:39:42PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 31-12-2010 2:23, Sarah Sharp wrote:
>
> >Make sure to call into the USB core's link, unlink, and giveback URB
> >functions with the usb_hcd pointer found by using urb->dev->bus. This
> >will avoid confusion later, when the xHCI driver will deal with URBs from
> >two separate buses (the USB 3.0 roothub and the faked USB 2.0 roothub).
>
> >Assume xhci_urb_dequeue() will be called with the proper usb_hcd.
>
> >Signed-off-by: Sarah Sharp<sarah.a.sharp@xxxxxxxxxxxxxxx>
> >---
> > drivers/usb/host/xhci-ring.c | 9 +++++----
> > drivers/usb/host/xhci.c | 2 +-
> > 2 files changed, 6 insertions(+), 5 deletions(-)
>
> >diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
> >index 6abe2e9..0a58be8 100644
> >--- a/drivers/usb/host/xhci-ring.c
> >+++ b/drivers/usb/host/xhci-ring.c
> >@@ -599,13 +599,14 @@ static inline void xhci_stop_watchdog_timer_in_irq(struct xhci_hcd *xhci,
> > static void xhci_giveback_urb_in_irq(struct xhci_hcd *xhci,
> > struct xhci_td *cur_td, int status, char *adjective)
> > {
> >- struct usb_hcd *hcd = xhci_to_hcd(xhci);
> >+ struct usb_hcd *hcd;
>
> Perhaps time to align with below variables?
I never align variables with tabs. I don't like the fact that if you
introduce a new variable with a longer type, you have to re-align all
the other variable declarations. It produces noise in the diff stats
that make it hard to pick out what really changed. CodingStyle says
nothing about aligning variables, so why bring it up when the style of
the driver isn't to align them?
Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
