On Wed, 22 Dec 2010, Sarah Sharp wrote: > Alan, > > Please take a look at patch 1 if you have time. I still don't understand the reason for adding that test to suspend_common(). (And I would prefer it if the comment above the test were more grammatical.) > Hi Andiry, > > It looks like these patches may have missed Greg's potentially-last pull > request for 2.6.37. I'll send the first (and possibly the 6th patch) to > Greg just in case Linus decides to do another rc. > > This patchset is a mixture of urgent bug fixes, new features, and > cleanup. In the future, can you break those up into separate patchsets? > > Here's my thoughts on getting these pushed: > > 1. synchronize irq - fixes some very scary warnings/errors on module > unload for Matthew and Rafael, so they should pushed sooner for 2.6.37. > > On the other hand, I'm a bit concerned about this bug fix because > Alan hasn't confirmed if all PCI host controllers set hcd->irq == > pci_dev->irq. I'm afraid a late fix will break some obscure PCI > host controller in a subtle way that will be hard to detect. The only host controller drivers that use usb_hcd_pci_pm_ops are uhci-hcd, ohci-hcd, ehci-hcd, and xhci-hcd. The first three all leave hcd->irq set to its default value of pci_dev->irq (apart from that unimportant exception in ohci-hcd.c). Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
