On Mon, Dec 20, 2010 at 03:23:35PM -0500, Vijay Kiran Kamuju wrote: <snip> Please don't send html email, the mailing lists reject it. Please reconfigure your email client to only send text. > > Why? You need to count "interrupts" not bytes received here. So it > > should be a simple increment of 1 added, not the number of bytes > > received. > > > Ok, I will increment it by one. > I used the ti_usb_3410_5052.c and ark3116.c as reference :) Those might only have 1 byte for a status :) > > > You also aren't setting any other of the icount variables, leaving them > > > > all to be 0, which really isn't helpful. Please set them to their > > > > proper values so that userspace can rely on them being correct. Right > > > > now it is better to not provide the ioctl at all instead of providing > > > > incorrect data. > > > > > > > > > > > I have updated the patch to set the variables related to the line status > > in > > > the icount, since there is no modem status register available for this > > one. > > > I hope every thing is ok in this second try. > > > If not please let me now. > > > > What about transmit interrupts? > > > > For the transmit interrupts I dont see any write_int_callback functionality > implemented. There is no "interrupt" write here. It's a bulk write that happens. > Hence I did not add the tx functionality. > Do I need to add new function write_int_callback. > You wrote parts of the driver till 2007 :P (I saw the copyright) The problem is, "interrupts" really don't mean anything to a usb to serial device, right? So you can either "guess" and try to count the urbs sent/received as an "interrupt" for this structure, or just not include the structure at all as it's pointless. Why are you adding this support? Is there a userspace application that requires it? If so, what does it do with this information and how will that really matter with a usb to serial device? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
