On Sat, Dec 18, 2010 at 01:17:15AM -0500, Vijay Kiran Kamuju wrote: > Hi, > > This is my first ever patch to linux kernel. > This is based on latest kernel development 2.6.37-rc6 > This patch implements the get_icount function for pl2303 driver, which is > needed for some software. > I do not have the actual hardware to test the patch, I have based this patch > on the other usb serial drivers. > Please test this driver and try to include in the latest 2.6.37 kernel. > Also send any comments and suggestions. Can you resend this in a format that I can apply it in (hint, read Documentation/SubmittingPatches and look at the section about "Signed-off-by:") > Thanks, > Vijay > --- drivers/usb/serial/pl2303.c.old 2010-12-17 12:04:25.886129002 -0500 > +++ drivers/usb/serial/pl2303.c 2010-12-17 12:12:43.734129002 -0500 Also, when generating your patch, please do it so that I can apply it with 'patch -p1', as that is what our tools expect. > @@ -152,6 +152,7 @@ > u8 line_control; > u8 line_status; > enum pl2303_type type; > + struct async_icount icount; > }; > > static int pl2303_vendor_read(__u16 value, __u16 index, > @@ -500,6 +501,8 @@ There's no context for these patches either, which is odd, care to regenerate it so we can see what functions are being modified? That way I can better review this as I think some of your logic can be moved around a bit to make it simpler overall. The idea and implementation is great though, thanks for doing this, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
