On Mon, Dec 20, 2010 at 05:22:09PM +0800, Ming Lei wrote:
Hi,
2010/12/20 Felipe Balbi <balbi@xxxxxx>:
On Mon, Dec 20, 2010 at 03:41:18PM +0800, Ming Lei wrote:
I think we can, instead, move all of those "the following field is only
used by tusb" to tusb glue layer. Put those on struct tusb_glue and
access them only from there.
If so, we need to access tusb specific type from musb core or musb dma,
seems not good since musb core or musb dma have to know if the current
glue driver is tusb, right?
Not necessarily, we can ask glue layer to write correct registers with
function pointers, for instance. But, like I said, I quickly looked at
that code, could be that it'd be a lot of work.
Yes, it should be a lot of work, so I suggest removing dependency on
CONFIG_USB_MUSB_TUSB6010 and other config options first in the
patch set.
Obviously, we can't do all cleanup in one single patch set, :-)
Could you agree on taking the method of the patch now?
Sure, we can split things more later.
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
