Hi, 2010/12/20 Felipe Balbi <balbi@xxxxxx>: > On Sun, Dec 19, 2010 at 10:58:59PM +0800, Ming Lei wrote: >> >> 2010/12/13 Felipe Balbi <balbi@xxxxxx>: >>> >>> Hi, >>> >>> On Mon, Dec 13, 2010 at 01:01:52AM +0800, tom.leiming@xxxxxxxxx wrote: >>>> >>>> From: Ming Lei <tom.leiming@xxxxxxxxx> >>>> >>>> This patch introduces MUSB_GLUE_TUSB_STYLE flag, which >>>> can be used to handle tusb dependent things by runtime >>>> method instead of previous static method. >>>> >>>> This patch handles tusb fifo style according to the flag >>>> of MUSB_GLUE_TUSB_STYLE passed from hw glue drivers. >>> >>> I'm not sure I like this approach. I didn't want musb to have to know >>> _where_ it's running. As long as platform sets up things correctly. >> >> We need to remove CONFIG_USB_MUSB_TUSB6010 first, so I think >> the method taken by the patch is doable for the purpose. >> >> Once we have better one, we can convert to it, but I find no better >> one than it at least now. > > I think we can, instead, move all of those "the following field is only > used by tusb" to tusb glue layer. Put those on struct tusb_glue and > access them only from there. If so, we need to access tusb specific type from musb core or musb dma, seems not good since musb core or musb dma have to know if the current glue driver is tusb, right? thanks, -- Lei Ming -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
