Hi,
On Sat, Dec 18, 2010 at 11:49:04AM +0800, Ming Lei wrote:
It seems it does use it still, in usb_hcd_platform_shutdown() -- at least
for the platform drivers that choose to call this function (but MUSB is not
amongst them)...
Considered at least usb_hcd_platform_shutdown insists on it, so suggest to
take this patch first to fix the kernel panic during s2ram.
If usb_hcd_platform_shutdown doesn't insist on it any longer, we can
use platform_set_drvdata to do it.
Felipe, your comments?
I'm not sure it's a good approach. MUSB doesn't use
usb_hcd_platform_shutdown and will never use it anyway. Fixing those
goofages is what we want at the end of the day. The problem here is
created by MUSB assuming it has to dev->driver_data to hcd, which isn't
true for its case.
So, I'd rather see a patch fixing allocate_instance(), another one
fixing dev_to_musb() and another one using platform_set_drvdata() on
musb's probe.
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
