Hi,
On Thu, Dec 16, 2010 at 06:06:25PM +0800, Ming Lei wrote:
2010/12/16 Felipe Balbi <balbi@xxxxxx>:
On Thu, Dec 16, 2010 at 02:14:35PM +0800, Ming Lei wrote:
struct musb_hdrc_config {
+ struct musb_fifo_cfg *fifo_cfg; /* board fifo configuration
*/
+ unsigned fifo_cfg_size; /* size of the fifo
configuration */
+
/* MUSB configuration-specific details */
unsigned multipoint:1; /* multipoint device */
unsigned dyn_fifo:1 __deprecated; /* supports dynamic fifo
sizing */
the thing is that we don't want to "bloat" musb_core.c with several
different fifo_modes and have each glue layer change that, instead we
can let board initialization data pass in an optmized version of the
fifo_mode the usecases the board will be used for.
But seems the commit can't meet my requirement, I just want to remove
the config options below to support one set of musb binary drivers for
multiple musb hw controller:
hmmm, I see. Ideally we wouldn't have that, those are only sane defaults
anyway.
/*musb_core.c*/
#if defined(CONFIG_USB_MUSB_TUSB6010) || defined(CONFIG_USB_MUSB_OMAP2PLUS) \
|| defined(CONFIG_USB_MUSB_AM35X)
static ushort __initdata fifo_mode = 4;
#else
static ushort __initdata fifo_mode = 2;
#endif
Any suggestions?
none whatsoever :-( But we need to drop those, for sure. Although I
think the way you proposed is kinda duplication, I think it's fine. At
least drops the ifdeferry.
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
